You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
read client-certificate flags from the located security.tls configuration
expose a peer principal when either required or optional client authentication is enabled
add regression coverage for nested TLS configuration
Root cause
SslConfig located the nested TLS block but read clientCertificateRequired and clientCertificateWanted from the outer endpoint configuration. SSLEndPoint also restricted principal extraction to required authentication only.
Impact
Configured client-certificate modes now reach the SSL engine, and optionally supplied client certificates can contribute the endpoint principal.
Validation
Added a unit test for nested security.tls client-certificate settings.
Dependency
The mandatory-handshake enforcement fix is in the companion authentication_library pull request from the same branch name.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 5994b75e-3ddf-4720-9b9d-a70397f63f1c
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
SslConfig located the nested TLS block but read clientCertificateRequired and clientCertificateWanted from the outer endpoint configuration. SSLEndPoint also restricted principal extraction to required authentication only.
Impact
Configured client-certificate modes now reach the SSL engine, and optionally supplied client certificates can contribute the endpoint principal.
Validation
Added a unit test for nested security.tls client-certificate settings.
Dependency
The mandatory-handshake enforcement fix is in the companion authentication_library pull request from the same branch name.